Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PCRE2_jll] Upgrade to 10.42 #47940

Merged
merged 2 commits into from
Dec 21, 2022
Merged

[PCRE2_jll] Upgrade to 10.42 #47940

merged 2 commits into from
Dec 21, 2022

Conversation

Seelengrab
Copy link
Contributor

Fixes #47936

I followed the usual memo by @giordano :

  • update the version number in stdlib/PCRE2_jll/Project.toml
  • update the version number in tests stdlib/PCRE2_jll/test/runtests.jl
  • update the version number in deps/pcre.version
  • refresh checksums with make -f contrib/refresh_checksums.mk -j pcre

Is the number of checksums there correct? Seems like there's only one now 🤔

@Seelengrab Seelengrab changed the title Bump version of PCRE [PCRE2_jll] Upgrade to 10.42 Dec 20, 2022
@giordano
Copy link
Contributor

Is the number of checksums there correct?

No, the name to pass to the Makefile is probably pcre2

@Seelengrab
Copy link
Contributor Author 

[sukera@tower julia]$ make -f contrib/refresh_checksums.mk -j pcre2
make: *** No rule to make target 'pcre2'.  Stop.
[sukera@tower julia]$ make -f contrib/refresh_checksums.mk -j PCRE2
make: *** No rule to make target 'PCRE2'.  Stop.
[sukera@tower julia]$ make -f contrib/refresh_checksums.mk -j PCRE
make: *** No rule to make target 'PCRE'.  Stop.

It does not like either of these, only pcre :/

@giordano
Copy link
Contributor

Did it download any files at all? Try removing the -j if you have race conditions

@Seelengrab
Copy link
Contributor Author

Seelengrab commented Dec 20, 2022 •
edited
Loading

That did it - ought to work now. If it does, this should be backportable, right?

@KristofferC
Copy link
Member

Maybe add the test from #47936 as well?

@giordano giordano mentioned this pull request Dec 20, 2022
Closed
@giordano giordano added building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs labels Dec 20, 2022
@KristofferC KristofferC added the backport 1.9 Change should be backported to release-1.9 label Dec 20, 2022
@martinholters
Copy link
Member

Backport to 1.6 as well, given that the upgrade that caused #47936 was backported (between 1.6.6 and 1.6.7)?

@KristofferC KristofferC added the backport 1.6 Change should be backported to release-1.6 label Dec 21, 2022
@KristofferC KristofferC mentioned this pull request Dec 21, 2022
Open
78 tasks
@KristofferC KristofferC merged commit 1c7cdd5 into JuliaLang:master Dec 21, 2022
KristofferC added a commit that referenced this pull request Dec 21, 2022
@KristofferC
Merge pull request #47940 from Seelengrab/bump_pcre
d32f0dd 
[PCRE2_jll] Upgrade to 10.42

(cherry picked from commit 1c7cdd5)
KristofferC added a commit that referenced this pull request Dec 21, 2022
@KristofferC
Merge pull request #47940 from Seelengrab/bump_pcre
81ceedf 
[PCRE2_jll] Upgrade to 10.42

(cherry picked from commit 1c7cdd5)
KristofferC added a commit that referenced this pull request Dec 21, 2022
@KristofferC
Merge pull request #47940 from Seelengrab/bump_pcre
141efcf 
[PCRE2_jll] Upgrade to 10.42

(cherry picked from commit 1c7cdd5)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@KristofferC @staticfloat
Merge pull request #47940 from Seelengrab/bump_pcre
4621789 
[PCRE2_jll] Upgrade to 10.42

(cherry picked from commit 1c7cdd5)
KristofferC added a commit that referenced this pull request Dec 28, 2022
@KristofferC
Merge pull request #47940 from Seelengrab/bump_pcre
ba741a4 
[PCRE2_jll] Upgrade to 10.42

(cherry picked from commit 1c7cdd5)
@KristofferC KristofferC mentioned this pull request Dec 28, 2022
Merged
14 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jan 2, 2023
KristofferC added a commit that referenced this pull request Oct 10, 2023
@KristofferC
Merge pull request #47940 from Seelengrab/bump_pcre
a9367cb 
[PCRE2_jll] Upgrade to 10.42

(cherry picked from commit 1c7cdd5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
backport 1.6 Change should be backported to release-1.6 building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regex fails expected match
4 participants
@Seelengrab @giordano @KristofferC @martinholters