-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CompilerSupportLibraries_jll] Add libssp
as product on Windows
#48012
Conversation
My only question is: do this only on Windows (where it's currently needed) or everywhere (we may need libssp in the future, but it isn't available on Musl). @staticfloat @vchuravy opinions? |
Now
|
Thanks for confirming it! I'm going to merge it now as-is, and if @staticfloat or someone else believes it'd be better to be more consistent across operating systems we can revise it for v1.9. |
Yes, I think it would be best to do this consistently across OS's, where possible. :) |
Background is https://discourse.julialang.org/t/glmakie-and-plots-fail-to-precompile-under-julia-1-8-4/92087. To summarise:
libssp-0.dll
was loaded automatically when loading libllvm until julia v1.8.3, only on Windows; on macOS and Linux I don’t see libssp loaded at any pointPATH
This PR explicitly adds
libssp
to the products ofCompilerSupportLibraries_jll
on Windows so that we can ensure this library is loaded whenCompilerSupportLibraries_jll
is used.