Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend method root to support more than 16bit roots #48185

Merged
merged 4 commits into from
Jan 9, 2023

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Jan 9, 2023

16bit outght to be enough for everyone?

Should fix #48089.

@vchuravy vchuravy added this to the 1.9 milestone Jan 9, 2023
@vchuravy vchuravy added the backport 1.9 Change should be backported to release-1.9 label Jan 9, 2023
@vchuravy vchuravy requested a review from JeffBezanson January 9, 2023 07:32
@vchuravy vchuravy merged commit 53a0a69 into master Jan 9, 2023
@vchuravy vchuravy deleted the vc/16bit_ought_to_be_enough branch January 9, 2023 14:11
@vchuravy
Copy link
Member Author

vchuravy commented Jan 9, 2023

Merged early to get CI back to green. @JeffBezanson if we should make TAG_METHODROOT uint16 I can do that in a follow on PR.

KristofferC pushed a commit that referenced this pull request Jan 10, 2023
@KristofferC KristofferC mentioned this pull request Jan 10, 2023
41 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: jl_encode_as_indexed_root: Assertion id <= (65535)' failed.
2 participants