distinguish "inlineable" from "declared as inline" #48250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
This commit addresses the current asymmetry in handling `@inline/@noinline` declarations by storing the information in `src::CodeInfo`. `src` now has the `inlining` field that indicates the inlining declaration as follows: - `src.inlining == 0`: no declaration - `src.inlining == 1`: declared as `@inline` - `src.inlining == 2`: declared as `@noinline` This change is a preparation for an upcoming refactor that will allow for judging inlineability at callsites of `is_inlineable`, while leaving the `inline_cost` function to simply compute the inlining cost without judging inlineability.
aviatesk
force-pushed
the
avi/inline-decl
branch
from
78c4f0e to
638ac2f
Compare
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the current asymmetry in handling
@inline/@noinlinedeclarations by storing the information insrc::CodeInfo.srcnow has theinliningfield that indicates the inlining declaration as follows:src.inlining == 0: no declarationsrc.inlining == 1: declared as@inlinesrc.inlining == 2: declared as@noinlineThis change is a preparation for an upcoming refactor that will allow for judging inlineability at callsites of
is_inlineable, while leaving theinline_costfunction to simply compute the inlining cost without judging inlineability.Replaces #41922.
@nanosoldier
runbenchmarks("inference", vs=":master")