Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs for try-catch-else #48414

Merged
merged 2 commits into from
Jan 26, 2023
Merged

add docs for try-catch-else #48414

merged 2 commits into from
Jan 26, 2023

Conversation

simeonschaub
Copy link
Member

ref #46928

@simeonschaub simeonschaub added backport 1.8 Change should be backported to release-1.8 backport 1.9 Change should be backported to release-1.9 docs This change adds or pertains to documentation labels Jan 26, 2023
IanButterworth
IanButterworth approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@IanButterworth IanButterworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some small suggestions

doc/src/manual/control-flow.md Show resolved Hide resolved
doc/src/manual/control-flow.md Outdated Show resolved Hide resolved
@simeonschaub @IanButterworth
Update doc/src/manual/control-flow.md
82695d3 
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
@simeonschaub simeonschaub added the merge me PR is reviewed. Merge when all tests are passing label Jan 26, 2023
@simeonschaub simeonschaub merged commit d775750 into master Jan 26, 2023
@simeonschaub simeonschaub deleted the sds/try_catch_else_docs branch January 26, 2023 22:50
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jan 27, 2023
KristofferC pushed a commit that referenced this pull request Feb 1, 2023
@simeonschaub @KristofferC
add docs for try-catch-else (#48414)
0a1da69 
ref #46928

Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
(cherry picked from commit d775750)
@KristofferC KristofferC mentioned this pull request Feb 1, 2023
Merged
35 tasks
KristofferC pushed a commit that referenced this pull request Feb 6, 2023
@simeonschaub @KristofferC
add docs for try-catch-else (#48414)
f66f52c 
ref #46928

Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
(cherry picked from commit d775750)
@KristofferC KristofferC mentioned this pull request Feb 6, 2023
Closed
16 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanButterworth IanButterworth IanButterworth approved these changes

Assignees
No one assigned
Labels
backport 1.8 Change should be backported to release-1.8 docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simeonschaub @IanButterworth @KristofferC @DilumAluthge