Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid generating native code if only output ji file #48431

Merged
merged 1 commit into from
Jan 28, 2023
Merged

avoid generating native code if only output ji file #48431

merged 1 commit into from
Jan 28, 2023

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jan 27, 2023

This seems to have been a minor build performance regression introduced in the incremental staticdata work.

@vtjnash vtjnash added regression Regression in behavior compared to a previous version backport 1.9 Change should be backported to release-1.9 labels Jan 27, 2023
@vtjnash vtjnash merged commit 2eeefbe into master Jan 28, 2023
@vtjnash vtjnash deleted the jn/ji-not-native branch January 28, 2023 05:49
@KristofferC KristofferC mentioned this pull request Feb 1, 2023
Merged
35 tasks
vtjnash added a commit that referenced this pull request Feb 6, 2023
@vtjnash
avoid generating native code if only output ji file (#48431)
62b70e3 
(cherry picked from commit 2eeefbe)
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timholy timholy timholy approved these changes

Assignees
No one assigned
Labels
regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtjnash @timholy @KristofferC