Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: add space after test failure for visual clarity #48526

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Feb 4, 2023

Small change. Currently sequential failures visually clump together.

Example failures

master

Pkg.precompile: Test Failed at /home/runner/work/Pkg.jl/Pkg.jl/test/api.jl:173
  Expression: length(broken_packages) == 1
   Evaluated: 0 == 1
Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:477 [inlined]
 [2] (::Main.PkgTestsOuter.PkgTestsInner.APITests.var"#17#32")(tmp::String)
   @ Main.PkgTestsOuter.PkgTestsInner.APITests ~/work/Pkg.jl/Pkg.jl/test/api.jl:173
Pkg.precompile: Test Failed at /home/runner/work/Pkg.jl/Pkg.jl/test/api.jl:181
  Expression: !(occursin("Precompiling", String(take!(iob))))
   Evaluated: !(occursin("Precompiling", "    Updating registry at `/tmp/jl_GaJgXM/registries/General`\n    Updating git-repo `[https://github.com/JuliaRegistries/General.git`\n](https://github.com/JuliaRegistries/General.git%60/n)  No Changes to `/tmp/jl_hEt56v/Project.toml`\n  No Changes to `/tmp/jl_hEt56v/Manifest.toml`\nPrecompiling project...\n\e[91m  ✗ \e[39mBrokenDep\n  0 dependencies successfully precompiled in 1 seconds. 6 already precompiled.\n  \e[91m1\e[39m dependency errored. To see a full report either run `import Pkg; Pkg.precompile()` or load the package\n"))
Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:477 [inlined]
 [2] (::Main.PkgTestsOuter.PkgTestsInner.APITests.var"#17#32")(tmp::String)
   @ Main.PkgTestsOuter.PkgTestsInner.APITests ~/work/Pkg.jl/Pkg.jl/test/api.jl:181
Pkg.precompile: Test Failed at /home/runner/work/Pkg.jl/Pkg.jl/test/api.jl:182
  Expression: length(Pkg.API.pkgs_precompile_suspended) == 1
   Evaluated: 0 == 1
Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:477 [inlined]
 [2] (::Main.PkgTestsOuter.PkgTestsInner.APITests.var"#17#32")(tmp::String)
   @ Main.PkgTestsOuter.PkgTestsInner.APITests ~/work/Pkg.jl/Pkg.jl/test/api.jl:182

This PR

Pkg.precompile: Test Failed at /home/runner/work/Pkg.jl/Pkg.jl/test/api.jl:173
  Expression: length(broken_packages) == 1
   Evaluated: 0 == 1
Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:477 [inlined]
 [2] (::Main.PkgTestsOuter.PkgTestsInner.APITests.var"#17#32")(tmp::String)
   @ Main.PkgTestsOuter.PkgTestsInner.APITests ~/work/Pkg.jl/Pkg.jl/test/api.jl:173

Pkg.precompile: Test Failed at /home/runner/work/Pkg.jl/Pkg.jl/test/api.jl:181
  Expression: !(occursin("Precompiling", String(take!(iob))))
   Evaluated: !(occursin("Precompiling", "    Updating registry at `/tmp/jl_GaJgXM/registries/General`\n    Updating git-repo `[https://github.com/JuliaRegistries/General.git`\n](https://github.com/JuliaRegistries/General.git%60/n)  No Changes to `/tmp/jl_hEt56v/Project.toml`\n  No Changes to `/tmp/jl_hEt56v/Manifest.toml`\nPrecompiling project...\n\e[91m  ✗ \e[39mBrokenDep\n  0 dependencies successfully precompiled in 1 seconds. 6 already precompiled.\n  \e[91m1\e[39m dependency errored. To see a full report either run `import Pkg; Pkg.precompile()` or load the package\n"))
Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:477 [inlined]
 [2] (::Main.PkgTestsOuter.PkgTestsInner.APITests.var"#17#32")(tmp::String)
   @ Main.PkgTestsOuter.PkgTestsInner.APITests ~/work/Pkg.jl/Pkg.jl/test/api.jl:181

Pkg.precompile: Test Failed at /home/runner/work/Pkg.jl/Pkg.jl/test/api.jl:182
  Expression: length(Pkg.API.pkgs_precompile_suspended) == 1
   Evaluated: 0 == 1
Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:477 [inlined]
 [2] (::Main.PkgTestsOuter.PkgTestsInner.APITests.var"#17#32")(tmp::String)
   @ Main.PkgTestsOuter.PkgTestsInner.APITests ~/work/Pkg.jl/Pkg.jl/test/api.jl:182

@IanButterworth IanButterworth added testsystem The unit testing framework and Test stdlib backport 1.9 Change should be backported to release-1.9 labels Feb 4, 2023
@KristofferC KristofferC mentioned this pull request Feb 20, 2023
50 tasks
@KristofferC KristofferC merged commit ba1e568 into JuliaLang:master Feb 21, 2023
@IanButterworth IanButterworth deleted the ib/test_fail_space branch February 21, 2023 13:44
KristofferC pushed a commit that referenced this pull request Mar 3, 2023
KristofferC pushed a commit that referenced this pull request Mar 3, 2023
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testsystem The unit testing framework and Test stdlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants