Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array: fix some atomic orderings #48888

Merged
merged 1 commit into from
Mar 4, 2023
Merged

array: fix some atomic orderings #48888

merged 1 commit into from
Mar 4, 2023

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Mar 3, 2023

There is nothing sensible to "release", but we prefer to make them relaxed stores so that the compiler cannot do anything too funky and accidentally tear a GC pointer in a data-race.

@vtjnash vtjnash added multithreading Base.Threads and related functionality merge me PR is reviewed. Merge when all tests are passing labels Mar 3, 2023
base/array.jl Outdated Show resolved Hide resolved
There is nothing sensible to "release", but we prefer to make them
relaxed stores so that the compiler cannot do anything too funky and
accidentally tear a GC pointer in a data-race.
@vtjnash vtjnash merged commit 6124987 into master Mar 4, 2023
@vtjnash vtjnash deleted the jn/unset-array-monotonic branch March 4, 2023 18:29
@vtjnash vtjnash added backport 1.9 Change should be backported to release-1.9 and removed merge me PR is reviewed. Merge when all tests are passing labels Mar 6, 2023
KristofferC pushed a commit that referenced this pull request Mar 7, 2023
@KristofferC KristofferC mentioned this pull request Mar 7, 2023
52 tasks
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multithreading Base.Threads and related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants