Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement specialized _findin when second arg is AbstractSet #48891

Merged
merged 1 commit into from
Feb 25, 2025
+3 −3
Merged

Implement specialized _findin when second arg is AbstractSet #48891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions base/array.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2809,14 +2809,14 @@ function indexin(a, b::AbstractArray)
]
end

function _findin(a::Union{AbstractArray, Tuple}, b)
function _findin(a::Union{AbstractArray, Tuple}, b::AbstractSet)
ind = Vector{eltype(keys(a))}()
bset = Set(b)
@inbounds for (i,ai) in pairs(a)
ai in bset && push!(ind, i)
ai in b && push!(ind, i)
end
ind
end
_findin(a::Union{AbstractArray, Tuple}, b) = _findin(a, Set(b))

# If two collections are already sorted, _findin can be computed with
# a single traversal of the two collections. This is much faster than
Expand Down