add overflow checking for abs(::Rational)
#48912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
approved these changes
Mar 6, 2023
oscardssmith
added
performance
|
Safer and 30% faster! (29 ns to 18 on my computer). |
|
Let's rerun CI for safety, though test failure seems to be due to internet connection issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #48744
Thanks to @mikmoore for pointing out the solution clearly. I have also added a test for the new functionality and a test for the
hashfunction (which has been changed) as well.I had made the PR earlier, but had to close and delete it because of some mistakes I made on the git side of things.