Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CFG corruption in CFG simplify #48962

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Fix CFG corruption in CFG simplify #48962

merged 1 commit into from
Mar 10, 2023

Commits on Mar 10, 2023

  1. Fix CFG corruption in CFG simplify

    IncrementalCompact ordinarily takes ownership of the CFG in order to to its
    transform. cfg_simplify! separate constructs the CFG transform structures
    ahead of time and was assuming this meant that the original CFG remained
    untouched (since it was using it for lookup operations). Unfortunately,
    the IncrementalCompact constructor was already doing some CFG manipulation
    cuasing the CFG to be corrupted and cfg_simplify! to create invalid IR.
    Fix that by refactoring the IncrementalCompact constructor to allow
    passing in the CFG transformation state explicitly, rather than poking
    it into the fields afterwards.
    Keno committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    8df7931 View commit details
    Browse the repository at this point in the history