fix multiq_check_empty to only look at the caller's pool #49065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
multithreading
KristofferC
pushed a commit
that referenced
this pull request
Mar 24, 2023
Co-authored-by: Jameson Nash <vtjnash@gmail.com> (cherry picked from commit 1323d2f)
Xnartharax
pushed a commit
to Xnartharax/julia
that referenced
this pull request
Apr 19, 2023
…9065) Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scheduler running on the current thread will only pull tasks from its own pool, so it should only check that pool in check_empty, instead of checking all pools. This is tricky to test since I think it basically just affects idle CPU use, but the change should be pretty clearly correct.