Handle `ProcessChain` in `open(f, cmd, ..)` #49166

hexaeder · 2023-03-27T17:28:56Z

Hey all,

On current master, open(f, cmds::pipeline) does not forward an exception inf but throws a MethodError since waitkill is only defined for Process. This PR extends it to ProcessChain. Maybe the type specification could be dropped entirely...

cmd = pipeline(`sleep 100`, `echo "foo"`)
open(cmd) do out
    error("my error")
end
# throws MethodError

cmd = `sleep 100`
open(cmd) do out
    error("my error")
end
# throws "my error" as expected

vtjnash

(regression introduced by #44078)

(cherry picked from commit 329f92c)

Handle ProcessChain in open(f, cmd, ..)

d3de770

vtjnash approved these changes Mar 27, 2023

View reviewed changes

fredrikekre added backport 1.8 Change should be backported to release-1.8 backport 1.9 Change should be backported to release-1.9 labels Mar 27, 2023

KristofferC mentioned this pull request Mar 30, 2023

Backports for 1.9.0-rc2 #48935

Merged

52 tasks

KristofferC merged commit 329f92c into JuliaLang:master Mar 30, 2023

KristofferC pushed a commit that referenced this pull request Mar 30, 2023

Handle ProcessChain in open(f, cmd, ..) (#49166)

5d17f1c

(cherry picked from commit 329f92c)

aviatesk pushed a commit that referenced this pull request Mar 30, 2023

Handle ProcessChain in open(f, cmd, ..) (#49166)

99a0d85

KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Mar 31, 2023

Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023

Handle ProcessChain in open(f, cmd, ..) (JuliaLang#49166)

f05b635

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle `ProcessChain` in `open(f, cmd, ..)` #49166

Handle `ProcessChain` in `open(f, cmd, ..)` #49166

hexaeder commented Mar 27, 2023

vtjnash left a comment

Handle ProcessChain in open(f, cmd, ..) #49166

Handle ProcessChain in open(f, cmd, ..) #49166

Conversation

hexaeder commented Mar 27, 2023

vtjnash left a comment

Choose a reason for hiding this comment

Handle `ProcessChain` in `open(f, cmd, ..)` #49166

Handle `ProcessChain` in `open(f, cmd, ..)` #49166