Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove alloca from codegen #49186

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Remove alloca from codegen #49186

merged 3 commits into from
Apr 10, 2023

Conversation

pchintalapudi
Copy link
Member

SmallVector is basically all of the upsides of alloca without any of the downsides.

@pchintalapudi pchintalapudi requested a review from vtjnash March 29, 2023 21:33
vtjnash
vtjnash approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(technically alloca may waste less stack space, since it is always sized exactly to the need, rather than being a static guess, but these probably didn't really need to be on the stack anyways)

@giordano giordano added the compiler:codegen Generation of LLVM IR and native code label Apr 3, 2023
@pchintalapudi pchintalapudi added the merge me PR is reviewed. Merge when all tests are passing label Apr 3, 2023
@vtjnash vtjnash merged commit ea72b94 into master Apr 10, 2023
@vtjnash vtjnash deleted the pc/alloca branch April 10, 2023 14:15
@oscardssmith oscardssmith removed the merge me PR is reviewed. Merge when all tests are passing label Apr 11, 2023
Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023
@pchintalapudi @Xnartharax
Remove alloca from codegen (JuliaLang#49186)
7ee9629 
Replace with SmallVector for better readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pchintalapudi @vtjnash @giordano @oscardssmith