Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug assert when using module as tparam #49292

Merged
merged 1 commit into from
Apr 8, 2023
Merged

Conversation

Keno
Copy link
Member

@Keno Keno commented Apr 8, 2023

This was an oversight in the implementation of #47749 and caused spurious asserts in debug mode:

julia> struct Foo{A, B}; end

julia> Foo{Base}
julia-debug: /home/keno/julia/src/builtins.c:350: type_object_id_: Assertion `!tv->name->mutabl' failed.

This was an oversight in the implementation of #47749 and caused
spurious asserts in debug mode:

```
julia> struct Foo{A, B}; end

julia> Foo{Base}
julia-debug: /home/keno/julia/src/builtins.c:350: type_object_id_: Assertion `!tv->name->mutabl' failed.
```
@Keno Keno merged commit 197710e into master Apr 8, 2023
@Keno Keno deleted the kf/modtparamassert branch April 8, 2023 08:21
Xnartharax pushed a commit to Xnartharax/julia that referenced this pull request Apr 19, 2023
This was an oversight in the implementation of JuliaLang#47749 and caused
spurious asserts in debug mode:

```
julia> struct Foo{A, B}; end

julia> Foo{Base}
julia-debug: /home/keno/julia/src/builtins.c:350: type_object_id_: Assertion `!tv->name->mutabl' failed.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant