Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guys, I saw the light, while I was struck by a thunder. Look what we can do! Let a generic
mul!
strip off potentialAdjOrTrans
wrappers, and peel off the actually data-storing array. With this design, it is crystal-clear what SparseArrays.jl, GPUArrays.jl and its surounding ecosystem need to overload. Not tons ofmul!
, butgeneric_matmatmul!
with all three matrix arguments of their own(ed) kind: SparseMatrixCSC, CuArray, MtlArray etc. In this PR, we have 4(!) methods as follows:That should be really helpful in terms of package load times.