Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CompilerSupportLibraries_jll] Upgrade to v1.0.5 #50135

Merged
merged 1 commit into from
Jun 11, 2023
Merged

[CompilerSupportLibraries_jll] Upgrade to v1.0.5 #50135

merged 1 commit into from
Jun 11, 2023

Conversation

giordano
Copy link
Contributor

@giordano giordano commented Jun 11, 2023 •
edited
Loading

This build includes a fix from GCC 12.2 for a bug in libgomp 12.1 which was causing frequent crashes on Windows in third-party libraries.

Quoting from JuliaPackaging/BinaryBuilderBase.jl#313

Ref: #48187. @jd-foster found that this was due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105745, after applying the patch to our GCC 12.1 build @tylerjthomas9 reported that the new libgomp made tests of XGBoost.jl and LIBSVM.jl pass.

Other related issues:

Fix #48187, fix #48907, fix #48573.

@giordano
[CompilerSupportLibraries_jll] Upgrade to v1.0.5
a523212 
This build includes a fix from GCC 12.2 for a bug in libgomp 12.1 which was
causing frequent crashes on Windows in third-party libraries.
@giordano giordano added system:windows Affects only Windows external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs backport 1.9 Change should be backported to release-1.9 labels Jun 11, 2023
@mkitti
Copy link
Contributor

mkitti commented Jun 11, 2023

What is the test procedure?

@giordano giordano mentioned this pull request Jun 11, 2023
Closed
@giordano
Copy link
Contributor Author

@mkitti confirmed on slack that with this branch XGBoost doesn't crash and all tests here are green, so I'm going to merge this PR so that people can use again external libraries on Windows, at least on nightly until 1.9.2 is released.

@giordano giordano merged commit a81398f into JuliaLang:master Jun 11, 2023
@giordano giordano deleted the mg/csl-libgomp-win branch June 11, 2023 20:47
This was referenced Jun 11, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@jishnub jishnub mentioned this pull request Jun 15, 2023
Merged
@simsurace
Copy link
Contributor

Will this definitely land on 1.9.2? I don't see any tag yet.

@ViralBShah
Copy link
Member

Will this definitely land on 1.9.2? I don't see any tag yet.

This PR does have the backport 1.9 label.

@jd-foster jd-foster mentioned this pull request Jun 23, 2023
Closed
KristofferC pushed a commit that referenced this pull request Jun 26, 2023
@giordano @KristofferC
[CompilerSupportLibraries_jll] Upgrade to v1.0.5 (#50135)
f6ce5dc 
This build includes a fix from GCC 12.2 for a bug in libgomp 12.1 which was
causing frequent crashes on Windows in third-party libraries.

(cherry picked from commit a81398f)
@KristofferC KristofferC mentioned this pull request Jun 26, 2023
Merged
36 tasks
@koehlerson koehlerson mentioned this pull request Jun 28, 2023
Merged
@KristofferC KristofferC removed the backport 1.9 Change should be backported to release-1.9 label Jul 10, 2023
@characat0 characat0 mentioned this pull request Apr 23, 2024
Merged
@barucden barucden mentioned this pull request May 13, 2024
Closed
@jd-foster jd-foster mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs system:windows Affects only Windows
Projects
None yet
Milestone
No milestone
5 participants
@giordano @mkitti @simsurace @ViralBShah @KristofferC