-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only tabcomplete public methods #50717
base: master
Are you sure you want to change the base?
Conversation
I feel a bit negatively towards such a change. Tab completion has been a useful "exploration" tool for me when trying to become a maintainer of a package I do not know well. On the other hand, I recognize it might be more important to stop novices from finding and relying on internal implementation details. I see this is exactly the sentiment expressed (and "thumbed-up" by 4 people) in #50105 (comment) Any chance it can be done so that tab-completion hides private symbols, but another completion hotkey is implemented that shows everything? |
I think the current implementation here is too harsh. Often one uses tab completion when working with ones own package to test and explore various internal fields and functions. |
I agree—this requires more consideration which is why I broke it off of #50105. |
Could we choose not to complete private names only for when doing |
Or perhaps they should be ordered to show public first (and print them in bold)? Agree that finding your way around the internals is one use of tab completion, if less common than just trying to figure out how to use the package as intended. |
Might be fine if inside the vscode extension here julia-vscode/julia-vscode#3240 with some configurations. |
Minor improvement to this: Make the public functions show last (and bold), because when tab completing your cursor will be moved after the suggestions and so you don't have to scroll up constantly. |
Followup for #50105