Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate implicit pseudo-inverses of vectors #50955

Closed

Conversation

antoine-levitt
Copy link
Contributor

See #49915. If we can't remove it, at least let's deprecate it. I'm still not super happy about it because deprecations aren't shown by default, but it's better than nothing.

Note that this now deprecates all pseudo-inverses, eg vector \ vector, unlike the previous PR that just removed real / vector.

@brenhinkeller brenhinkeller added speculative Whether the change will be implemented is speculative linear algebra Linear algebra labels Aug 17, 2023
@brenhinkeller
Copy link
Contributor

brenhinkeller commented Aug 17, 2023

I don't know if there's really much point adding deprecations for breaking changes that we can't make
Eh, I guess I take that back if there's no performance implication and there's general agreement this is wanted in 2.0 and adding this now makes that easier

@brenhinkeller brenhinkeller removed the speculative Whether the change will be implemented is speculative label Aug 17, 2023
@antoine-levitt
Copy link
Contributor Author

We can still send a signal "this function was a mistake, don't use it, and hypothetically if we ever get around to making breaking changes we'll remove it"

@antoine-levitt
Copy link
Contributor Author

Can we merge this?

@DilumAluthge
Copy link
Member

We have moved the LinearAlgebra stdlib to an external repo: https://github.com/JuliaLang/LinearAlgebra.jl

@antoine-levitt If you think that this PR is still relevant, please open a new PR on the LinearAlgebra.jl repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants