Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public keyword to NEWS.md #51322

Merged
merged 4 commits into from
Sep 23, 2023
Merged

Add public keyword to NEWS.md #51322

merged 4 commits into from
Sep 23, 2023

Conversation

LilithHafner
Copy link
Member

No description provided.

@LilithHafner LilithHafner added the docs This change adds or pertains to documentation label Sep 14, 2023
@IanButterworth
Copy link
Member

Perhaps should the public entry in the docs have a !!! compat entry?
Also is this backwards compatible? Do older versions just ignore it or fail to parse?

@LilithHafner
Copy link
Member Author

On old versions, it fails to parse. You can use @public from JuliaLang/Compat.jl#805.
Yes, it should have a compat entry.

@LilithHafner
Copy link
Member Author

LilithHafner commented Sep 15, 2023 •
edited
Loading

This PR now depends on JuliaLang/Compat.jl#805.
I address your !!! compat comment in #51333

fredrikekre
fredrikekre reviewed Sep 15, 2023
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
LilithHafner and others added 2 commits September 23, 2023 11:18
@LilithHafner @fredrikekre
Change description
36ed44a 
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
@LilithHafner
Merge branch 'master' into LilithHafner-patch-3
fbb0b49
@LilithHafner LilithHafner merged commit 9bf2620 into master Sep 23, 2023
1 check passed
@LilithHafner LilithHafner deleted the LilithHafner-patch-3 branch September 23, 2023 18:01
@LilithHafner LilithHafner mentioned this pull request Sep 23, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LilithHafner @IanButterworth @fredrikekre