Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport a fix for GMP patches to backports-release-1.10 #51445

Conversation

Drvi
Copy link
Contributor

@Drvi Drvi commented Sep 25, 2023

This backports Fixes and improvements for source builds (#51422) PR to the backports-release-1.10 branch to make it buildable without binary builder (we are monitoring that branch in our CI to make sure we are up to date with the upcoming 1.10 release).

Merging this PR should be followed by removing the backport 1.10 label from #51422

I hope this PR makes the backporting process easier for you, please let me know if that is not the case.

- A GMP patch was malformed; copy the corrected version from Yggdrasil
- Always invoke `patch` with `-f` to avoid interactive prompts during
build
- Don't quote the path to `python`, or nghttp2's configure script fails
with `error: Python interpreter is too old` (but `config.log` reveals
`"/usr/bin/python": No such file or directory`)

(cherry picked from commit 5d44a37)
@KristofferC KristofferC merged commit 491dfb5 into JuliaLang:backports-release-1.10 Sep 25, 2023
1 of 6 checks passed
@brenhinkeller brenhinkeller added the building Build system, or building Julia or its dependencies label Oct 3, 2023
nalimilan pushed a commit that referenced this pull request Nov 5, 2023
This backports `Fixes and improvements for source builds (#51422)` PR to
the `backports-release-1.10` branch to make it buildable without binary
builder (we are monitoring that branch in our CI to make sure we are up
to date with the upcoming 1.10 release).

Co-authored-by: Tim Besard <tim.besard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants