Take default GC choices always #51564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d-netto can you check if this doesn't make the performance too much worse? |
NHDaly
reviewed
Oct 4, 2023
|
We backported this PR and ran our internal CI with it. There seems to be OOM kills in a couple of tests. |
|
FWIW I can reproduce the issue reported on #51601 with this PR. Peak RSS on 1.9 is around 400MB-500MB, and with this PR it goes beyond 60GB and fails on the serialization step of GCBenchmarks. |
+ adjust the target heap if too much gets freed out of GC + add the counted realloc size to the old gen
|
I don't know if you wanted to pull out the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert only the automatic tuning of the GC because there are some issues with it. @d-netto is looking into them but it's probably not going to be done for 1.10