Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more module declaration formats in module check #51689

Merged

Conversation

IanButterworth
Copy link
Member

Motivated by #51635 (comment)

@fatteneder
Copy link
Member

I wonder if using Meta.parse(extfile) and subsequent scanning of the AST would give an even more robust solution?

@KristofferC
Copy link
Member

Seems like this doesn't fully work.

@IanButterworth
Copy link
Member Author

I wonder if using Meta.parse(extfile) and subsequent scanning of the AST would give an even more robust solution?

@fatteneder the reason I didn't do that is this is supposed to be very efficient in valid files, so it returns early. I think Meta.parse would do more work in most cases

@IanButterworth IanButterworth merged commit 86305e3 into JuliaLang:master Oct 19, 2023
6 checks passed
@IanButterworth IanButterworth deleted the ib/module_check_expand branch October 19, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants