Fix off-by-one error in annotated string concat #51803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new unit test is also added for the edge-case found, and a few details of the test string adjusted to make it easier to reason about at a glance.
|
The CI errors seem to be with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new unit test is also added for the edge-case found, and a few details of the test string adjusted to make it easier to reason about at a glance.
This seems to have slipped into #49586 when the
annotatedstringfunction had to be refactored to no longer useeachstyle(which was moved into the stdlib), and escaped the unit tests for index corectness.