-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use StyledStrings
for REPL prompt styling
#51887
Draft
caleb-allen
wants to merge
15
commits into
JuliaLang:master
Choose a base branch
from
caleb-allen:caleb-allen/repl-styling-with-annotated-strings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Use StyledStrings
for REPL prompt styling
#51887
caleb-allen
wants to merge
15
commits into
JuliaLang:master
from
caleb-allen:caleb-allen/repl-styling-with-annotated-strings
Commits on Nov 1, 2023
-
This gets us two commits of interest: - Replace within-module eval with hygienic eval: which makes it possible to include StyledStrings in the sysimage without running into precompile errors. - Load the JULIA_*_COLOR env vars for compat: which mirrors the current behaviour to the relevant faces.
Configuration menu - View commit details
-
Copy full SHA for 621e646 - Browse repository at this point
Copy the full SHA 621e646View commit details -
By loading the StyledStrings stdlib in REPL, we load the privateered print/show methods for the Annotated{String,Char} types defined there. This is nice to have, because it means that styled annotated strings can be constructed in Base and elsewhere without loading the StyledStrings stdlib, but they will be displayed as intended in the REPL.
Configuration menu - View commit details
-
Copy full SHA for 887c3ee - Browse repository at this point
Copy the full SHA 887c3eeView commit details
Commits on Nov 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 40af7f8 - Browse repository at this point
Copy the full SHA 40af7f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8820b92 - Browse repository at this point
Copy the full SHA 8820b92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 045d5e8 - Browse repository at this point
Copy the full SHA 045d5e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1039f60 - Browse repository at this point
Copy the full SHA 1039f60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 498cfa8 - Browse repository at this point
Copy the full SHA 498cfa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a30278a - Browse repository at this point
Copy the full SHA a30278aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 212a1b1 - Browse repository at this point
Copy the full SHA 212a1b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36b2a21 - Browse repository at this point
Copy the full SHA 36b2a21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7631901 - Browse repository at this point
Copy the full SHA 7631901View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30545b7 - Browse repository at this point
Copy the full SHA 30545b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51309a6 - Browse repository at this point
Copy the full SHA 51309a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfbf552 - Browse repository at this point
Copy the full SHA dfbf552View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25f50f6 - Browse repository at this point
Copy the full SHA 25f50f6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.