Fix task suspension in GC for JL_TIMING #52005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timing system does not currently support nesting task suspensions, so this `JL_TIMING_SUSPEND_TASK` added in JuliaLang#51489 is not permitted since it is called from within the GC suspension. This was causing Tracy to crash upon recording with "zone ended twice"
vtjnash
approved these changes
Nov 2, 2023
oscardssmith
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timing system does not currently support nesting task suspensions, so this
JL_TIMING_SUSPEND_TASKadded in #51489 is not permitted since it is called from within the GC suspension.This was causing Tracy to crash upon recording with "zone ended twice"