Skip to content

Limit REPL suggestions to modules from which name is exported/public #52418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2023
Merged

Limit REPL suggestions to modules from which name is exported/public #52418

merged 1 commit into from
Dec 8, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 6, 2023

Close #52387 by implementing the suggestion in #52387 (comment). After this, in a fresh session

julia> Diagonal
ERROR: UndefVarError: `Diagonal` not defined in `Main`
Suggestion: check for spelling errors or missing imports.
Hint: a global variable of this name also exists in LinearAlgebra.

@jishnub jishnub requested a review from vtjnash December 8, 2023 03:31
@vtjnash vtjnash merged commit 5dfaef7 into master Dec 8, 2023
@vtjnash vtjnash deleted the jishnub/replsuggestion branch December 8, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UndefVarError suggestions should only point to explicit owners of name
2 participants
@jishnub @vtjnash