Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specialize copy for Diagonal #52500

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Specialize copy for Diagonal #52500

merged 1 commit into from
Dec 18, 2023

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Dec 12, 2023

On master

julia> copy(Diagonal(1:4)) |> typeof
Diagonal{Int64, Vector{Int64}}

This PR

julia> copy(Diagonal(1:4)) |> typeof
Diagonal{Int64, UnitRange{Int64}}

Similar methods already exist for Bidiagonal and Tridiagonal, but this was missing for Diagonal.

@jishnub jishnub added the linear algebra Linear algebra label Dec 12, 2023
@jishnub jishnub requested a review from dkarrasch December 18, 2023 02:25
@jishnub jishnub merged commit 7fe08e0 into master Dec 18, 2023
3 checks passed
@jishnub jishnub deleted the jishnub/diagcopy branch December 18, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jishnub @dkarrasch