-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstring for TOML stdlib module #52834
Add docstring for TOML stdlib module #52834
Conversation
Looks good to me, thanks for contributing! |
This isn't |
Whoops, right, I didn't notice that the docstring was in the wrong place. Just move this docstring to (It wouldn't hurt to add a docstring to |
Hi, Thanks for pointing it out @fredrikekre. I moved the docstring to TOML.jl and added another docstring in toml_parser.jl to discourage its use. |
Improved Docstring Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
…uliaTomlDoc into docstring-toml-branch
Now that #52723 is merged, you'll need to update julia/stdlib/TOML/test/runtests.jl Lines 29 to 33 in f286d44
@testset "Docstrings" begin
@test isempty(Docs.undocumented_names(TOML))
end |
Hi, I have updated the runtests.jl. Thanks! |
LGTM, thanks! |
The file got commited in JuliaLang#52834 and seems useless.
The file got commited in #52834 and seems useless.
This is a PR for the issue #52725.
Thanks!