add code loading support for workspaces #53653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
force-pushed
the
kc/subprojects
branch
2 times, most recently
from
e5ccebf
to
afebb38
Compare
5 tasks
|
Corresponding Pkg PR at JuliaLang/Pkg.jl#3841. |
KristofferC
force-pushed
the
kc/subprojects
branch
from
7d5a951
to
a11e2e4
Compare
base/precompilation.jl
Outdated
Comment on lines
66
to
77
| end | ||
|
|
||
| if !project_is_package |
There was a problem hiding this comment.
Suggested change
| end | |
| if !project_is_package | |
| else |
There was a problem hiding this comment.
I actually kind of want to have these separate because they do sort of different things so it makes sense to me that they are properly separated.
KristofferC
force-pushed
the
kc/subprojects
branch
2 times, most recently
from
d04ce6a
to
0abc479
Compare
|
Need to check that extensions are identified properly with this. |
KristofferC
force-pushed
the
kc/subprojects
branch
from
12efa32
to
7dabb21
Compare
KristofferC
changed the title
|
I think this PR is pretty much done now if someone wants to look over it. |
KristofferC
force-pushed
the
kc/subprojects
branch
from
62e160e
to
6c445c4
Compare
KristofferC
force-pushed
the
kc/subprojects
branch
from
35b2008
to
93d1fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to workspaces in cargo where multiple projects share a manifest https://doc.rust-lang.org/book/ch14-03-cargo-workspaces.html and upon resolving the dependencies and compat of all projects in the workspace is adhered to.
The idea is to use this for e.g. test, doc environments where you want to "overlay" a dependency graph on top of a base one.
The corresponding Pkg part of this is yet to be written.
Happy for input regarding the terminology here. I didn't adopt the "workspace" terminology here because the "base project" will typically not be empty (it will be the package project) and I think that is different from how it is in Cargo where there are no dependencies in that base project.