Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make REPL.TerminalMenus.terminal type stable #53704

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

aviatesk
Copy link
Member

No description provided.

Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this is global, since that seems a pretty bad idea, but I would assume this is something like an AbstractTerminal, not specifically TTYTerminal

@aviatesk
Copy link
Member Author

I guess this can be wrapped into a function instead?

@aviatesk aviatesk force-pushed the avi/terminal-menus branch from 83a2d6d to 875d446 Compare March 13, 2024 03:13
@aviatesk aviatesk merged commit 5023ee2 into master Mar 14, 2024
7 checks passed
@aviatesk aviatesk deleted the avi/terminal-menus branch March 14, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants