Commits on Mar 14, 2024

1. inlining: bail out unless match.spec_types <: match.method.sig …

   As Jameson pointed out in the link below, while the union-split handles
   cases when there are uncovered matches, sometimes the expected condition
   `spec_types <: method.sig` that the union-split algorithm relies on
   isn't met in such cases, which caused issues like #52644. This commit
   fixes the problem by adding explicit checks for such cases. Note that
   this is based on #52092. The extra handling for single method match
   unmatched static parameters based on `only_method` that was removed in
   JuliaLang/#52092 has been ineffective and would otherwise cause
   problematic inlining on this PR. We'll likely need to come back to this
   later and figure out a safe and effective way to deal with such cases
   in the future when the handling for either case turns out to be
   necessary.
   
   - closes #52644
   - xref: <#53600 (review)>

   

   aviatesk committed Mar 14, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 63e75e8
   • Browse repository at this point

   Copy the full SHA

   63e75e8 View commit details

   Browse the repository at this point in the history