-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust test to error message change in #53778 #53813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this breaks consistency with many other file methods (though I didn't check specifically). It seems somewhat rude to windows users to make it so they can't copy paste this text, even though the " make it look like a string
I considered changing the error message back, but I actually think non-escaped filenames make more sense here, so I just adjusted the test. We can do either though.
I'll let you debate that with @JeffBezanson. I do find the double backslash somewhat ugly there. Maybe it should go into cmd ticks? Anyway, I just want CI to pass. |
I believe this is still failing?
|
In case this isn't resolved soon I've reopened and rebased the revert #53808 - Now merged |
Ok I think we can put the repr's back for now. But it would be better to call some more specific string escaping function if that's what's needed. |
Note the other error in that same function doesn't call |
I considered changing the error message back, but I actually think non-escaped filenames make more sense here, so I just adjusted the test. We can do either though.