Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libgit2 to 1.8.0 #53840

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Update libgit2 to 1.8.0 #53840

merged 1 commit into from
Mar 26, 2024

Conversation

fxcoudert
Copy link
Contributor

According to the release notes, three breaking (ABI) changes are handled here:

  • GIT_CONFIG_LEVEL_WORKTREE constant (and modification to value of GIT_CONFIG_LEVEL_APP)
  • git_config_entry structure
  • git_push_options structure

https://github.com/libgit2/libgit2/releases/tag/v1.8.0

@fxcoudert
Copy link
Contributor Author

One thing I don't understand is: why does stdlib/LibGit2/Project.toml say:

name = "LibGit2"
uuid = "76f85450-5226-5b5a-8eaa-529ad045b433"
version = "1.11.0"

The version is not the same for LibGit2_jll and LibGit2. Where does that LibGit2 version come from? And what does that mean for checks like if LibGit2.VERSION >= v"1.8.0", meaning, are they actually correct or not?

@fxcoudert
Copy link
Contributor Author

Is testing expected to be clean?

@KristofferC
Copy link
Sponsor Member

One thing I don't understand...

This is the version of the julia package LibGit2 that wraps the libgit2 library. Stdlibs usually had no versions but this was awkward so in 1.11 they where somewhat arbitrarily assigned the version of the current julia version. LibGit2.VERSION is unrelated to this value.

@fxcoudert
Copy link
Contributor Author

Then I think this is ready to merge

@giordano giordano merged commit 64de065 into JuliaLang:master Mar 26, 2024
7 checks passed
@giordano giordano added building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs labels Mar 26, 2024
@fxcoudert fxcoudert deleted the libgit2 branch March 26, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants