remove hand-coded methods for (U)Int128 on 32 bit systems #53867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
added
system:32-bit
|
given that CI is passing, is this good to merge? |
gbaraldi
approved these changes
Apr 16, 2024
|
It used to be there to workaround the absence of compiler-rt that should be provided by us on those systems, as required by LLVM. We haven't started to provide that, as far as I know, but I guess maybe LLVM doesn't require it anymore? |
|
I believe LLVM has started supporting it natively, but I'm not 100% sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this code existed to work around bugs that LLVM used to have with 128 bit numbers on 32 bit systems, but I'm not entirely sure.