More tests for irrationals #54172
Merged
More tests for irrationals #54172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
test
| @testset "Irrational promote_type" begin | ||
| for T in (Float16, Float32, Float64) | ||
| for i in (π, ℯ, γ, catalan) | ||
| @test T(2.0) * i ≈ T(2.0) * T(i) |
Member
There was a problem hiding this comment.
This happens to pass with ===, but I agree with your choice to use isapprox instead.
LilithHafner
approved these changes
Apr 21, 2024
oscardssmith
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveralls.io/builds/67039158/source?filename=base%2Firrationals.jl according to coveralls some of this isn't covered