Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for task.scope #54180

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Better error message for task.scope #54180

merged 4 commits into from
Apr 23, 2024

Conversation

LilithHafner
Copy link
Member

Fixes #54178

@LilithHafner LilithHafner added the error messages Better, more actionable error messages label Apr 21, 2024
@LilithHafner LilithHafner requested a review from Keno April 21, 2024 18:37
@LilithHafner
Copy link
Member Author

Semantic merge conflict with #54176

Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

base/task.jl Outdated Show resolved Hide resolved
@LilithHafner LilithHafner added the DO NOT MERGE Do not merge this PR! label Apr 21, 2024
@LilithHafner
Copy link
Member Author

Waiting for #54176 to merge.

Intentionally use a different string literal syntax for better test robustness.
@LilithHafner LilithHafner added merge me PR is reviewed. Merge when all tests are passing and removed DO NOT MERGE Do not merge this PR! labels Apr 22, 2024
@fatteneder fatteneder merged commit 53f452a into master Apr 23, 2024
6 of 9 checks passed
@fatteneder fatteneder deleted the lh/task-scope branch April 23, 2024 21:56
@fatteneder fatteneder removed the merge me PR is reviewed. Merge when all tests are passing label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error messages Better, more actionable error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

current_scope is recommended by an error message but inaccessible.
3 participants