Restructure performance tips #54211
Merged
Restructure performance tips #54211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abraemer
reviewed
Apr 23, 2024
LilithHafner
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
I think this is an overall improvement. There is certainly room for more, but I think @gdalle's decision to restrict this PR to exclusively rearrangement is a good one.
Unless someone thinks this is not an overall improvement, I'll go ahead and merge it.
LilithHafner
added
docs
LilithHafner
pushed a commit
that referenced
this pull request
Jul 25, 2024
There's a few reasons for making it public: - It's already mentioned in the manual (#54211). - It's the easiest way to deprecate a function that shouldn't be used anymore at all. - It's already widely used in the ecosystem: https://juliahub.com/ui/Search?type=code&q=Base.depwarn( I also moved the `@deprecate` docs into a new `Managing deprecations` section because I felt it should go together with `Base.depwarn()`. Might be worth backporting to 1.11?
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Aug 17, 2024
There's a few reasons for making it public: - It's already mentioned in the manual (JuliaLang#54211). - It's the easiest way to deprecate a function that shouldn't be used anymore at all. - It's already widely used in the ecosystem: https://juliahub.com/ui/Search?type=code&q=Base.depwarn( I also moved the `@deprecate` docs into a new `Managing deprecations` section because I felt it should go together with `Base.depwarn()`. Might be worth backporting to 1.11?
KristofferC
pushed a commit
that referenced
this pull request
Aug 19, 2024
There's a few reasons for making it public: - It's already mentioned in the manual (#54211). - It's the easiest way to deprecate a function that shouldn't be used anymore at all. - It's already widely used in the ecosystem: https://juliahub.com/ui/Search?type=code&q=Base.depwarn( I also moved the `@deprecate` docs into a new `Managing deprecations` section because I felt it should go together with `Base.depwarn()`. Might be worth backporting to 1.11? (cherry picked from commit 442f9d5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the documentation page on "performance tips" more accessible and structured.
Ping @abraemer, @adrhill, @jacobusmmsmit
No content has been modified, this is strictly copy-paste and moving things around