Highlight julia-repl code in Markdown specially #54423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the approach taken by OhMyREPL.jl, and make the highlighting of julia-repl and jldoctest more closely mirror the REPL experience. This code was originally part of 1614e11, but was separated out at Jameson's request so it could be discussed seperately.
tecosaur
added
display and printing
|
It would be nice for users if the help prompt could always use the less-confusing rendering of the |
|
Sounds good to me, I think the question then is just what the default should be. |
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Jul 12, 2024
Fixes JuliaLang#54399 by re-introducing the code seperated out from the styled Markdown PR at Jameson's request (JuliaLang#51928 (comment)). The code itself is modelled after [equivalent code in OhMyREPL](https://github.com/KristofferC/OhMyREPL.jl/blob/b0071f5ee785a81ca1e69a561586ff270b4dc2bb/src/MarkdownHighlighter.jl#L15-L31). The new `markdown_julia_prompt` face allows people to make the "prompt" shown in Markdown code visually distinct, to [avoid confusing it with the REPL prompt at a glance](KristofferC/OhMyREPL.jl#100). By way of example, I make it italic by augmenting my `faces.toml` with ```toml [markdown] julia_prompt = { italic = true } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54399 by re-introducing the code seperated out from the styled Markdown PR at Jameson's request (#51928 (comment)).
The code itself is modelled after equivalent code in OhMyREPL.
Sample:
Bonus:
The new
markdown_julia_promptface allows people to make the "prompt" shown in Markdown code visually distinct, to avoid confusing it with the REPL prompt at a glance. By way of example, I make it italic by augmenting myfaces.tomlwith