Add sort for NTuples, make it extensible by packages, and make DefaultStable and DefaultUnstable dispatchable #54494
+114
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble and DefaultUnstable dispatchable, and add tests
LilithHafner
added
sorting
LilithHafner
changed the title
nsajko
reviewed
May 17, 2024
lgoettgens
reviewed
May 17, 2024
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
KristofferC
reviewed
May 17, 2024
|
What does the "make it extensible by packages" part mean? |
|
One can specialize on the alg keyword argument and on the eltype of the NTuple with this implementation. With the last implementation one could only specialize on eltype of the NTuple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54489
This is partially a reland of #46104, but without the controversial
sort(x) = sort!(copymutable(x))and with some extensibility improvements.