Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix prepend StackOverflow issue #54718

Merged
merged 5 commits into from
Jun 7, 2024
Merged

fix prepend StackOverflow issue #54718

merged 5 commits into from
Jun 7, 2024

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jun 6, 2024

Attempt to fix #54711
Test introduced by #36227

@vtjnash
fix prepend StackOverflow issue
3e2dc41 
Attempt to fix #54711
Test introduced by #36227
@vtjnash vtjnash added arrays [a, r, r, a, y, s] backport 1.11 Change should be backported to release-1.11 labels Jun 6, 2024
aviatesk
aviatesk reviewed Jun 7, 2024
View reviewed changes
base/array.jl Outdated Show resolved Hide resolved
base/array.jl Outdated Show resolved Hide resolved
@KristofferC KristofferC mentioned this pull request Jun 7, 2024
Merged
60 tasks
aviatesk
aviatesk reviewed Jun 7, 2024
View reviewed changes
base/array.jl Outdated Show resolved Hide resolved
vtjnash
vtjnash commented Jun 7, 2024
View reviewed changes
base/array.jl Outdated Show resolved Hide resolved
@aviatesk @vtjnash
Update base/array.jl
58c81d3 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@aviatesk aviatesk merged commit 9477472 into master Jun 7, 2024
6 of 7 checks passed
@aviatesk aviatesk deleted the jn/54711 branch June 7, 2024 17:11
KristofferC pushed a commit that referenced this pull request Jun 13, 2024
@vtjnash
fix prepend StackOverflow issue (#54718)
fe51261 
Attempt to fix #54711
Test introduced by #36227

---------

Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
(cherry picked from commit 9477472)
@staticfloat
Copy link
Member

@vtjnash We are seeing that #52434 no longer seems to happen after this was merged. Could this have possibly fixed that issue on aarch64 as well?

@vtjnash
Copy link
Member Author

vtjnash commented Jun 17, 2024

That issue had 2 causes. One was a kernel bug (#52434 (comment)) and the other was this PR

@giordano
Copy link
Contributor

The kernel issue was related only to the SharedArrays issue, the discussion in the thread mixed two separate issues.

@staticfloat staticfloat mentioned this pull request Jun 17, 2024
Closed
KristofferC added a commit that referenced this pull request Jun 25, 2024
@KristofferC
Backports for 1.11.0-rc1 (#54611)
ec84807 
Backported PRs:
- [x] #54361 <!-- [LBT] Upgrade to v5.9.0 -->
- [x] #54474 <!-- Unalias source from dest in copytrito -->
- [x] #54548 <!-- Fixes for bitcast bugs with LLVM 17 / opaque pointers
-->
- [x] #54191 <!-- make `AbstractPipe` public -->
- [x] #53402 <!-- Add `jl_getaffinity` and `jl_setaffinity` -->
- [x] #53356 <!-- Rename at-scriptdir project argument to at-script and
search upwards for Project.toml -->
- [x] #54545 <!-- typeintersect: fix incorrect innervar handling under
circular env -->
- [x] #54586 <!-- Set storage class of julia globals to dllimport on
windows to avoid auto-import weirdness. Forward port of #54572 -->
- [x] #54587 <!-- Accomodate for rectangular matrices in `copytrito!`
-->
- [x] #54617 <!-- CLI: Use `GetModuleHandleExW` to locate libjulia.dll
-->
- [x] #54605 <!-- Allow libquadmath to also fail as it is not available
on all systems -->
- [x] #54634 <!-- Fix trampoline assembly for build on clang 18 on apple
silicon -->
- [x] #54635 <!-- Aggressive constprop in trevc! to stabilize triangular
eigvec -->
- [x] #54645 <!-- ensure we set the right value to gc_first_tid -->
- [x] #54554 <!-- make elsize public -->
- [x] #54648 <!-- Construct LazyString in error paths for tridiag -->
- [x] #54658 <!-- fix missing uuid check on extension when finding the
location of an extension -->
- [x] #54594 <!-- Switch to Pkg mode prompt immediately and load Pkg in
the background -->
- [x] #54669 <!-- Improve error message in inplace transpose -->
- [x] #54671 <!-- Add boundscheck in bindingkey_eq to avoid OOB access
due to data race -->
- [x] #54672 <!-- make: Fix `sed` command for LLVM libraries with no
symbol versioning -->
- [x] #54624 <!-- more precise aliasing checks for SubArray -->
- [x] #54679 <!-- 🤖 [master] Bump the Distributed stdlib from 6a07d98 to
6c7cdb5 -->
- [x] #54604 <!-- Fix tbaa annotation on union selector bytes inside of
structs -->
- [x] #54690 <!-- Fix assertion/crash when optimizing function with dead
basic block -->
- [x] #54704 <!-- LazyString in reinterpretarray error messages -->
- [x] #54718 <!-- fix prepend StackOverflow issue -->
- [x] #54674 <!-- Reimplement dummy pkg prompt as standard prompt -->
- [x] #54737 <!-- LazyString in interpolated error messages involving
types -->
- [x] #54642 <!-- Document GenericMemory and AtomicMemory -->
- [x] #54713 <!-- make: use `readelf` for LLVM symbol version detection
-->
- [x] #54760 <!-- REPL: improve prompt! async function handler -->
- [x] #54606 <!-- fix double-counting and non-deterministic results in
`summarysize` -->
- [x] #54759 <!-- REPL: Fully populate the dummy Pkg prompt -->
- [x] #54702 <!-- lowering: Recognize argument destructuring inside
macro hygiene -->
- [x] #54678 <!-- Don't let setglobal! implicitly create bindings -->
- [x] #54730 <!-- Fix uuidkey of exts in fast path of `require_stdlib`
-->
- [x] #54765 <!-- Handle no-postdominator case in finalizer pass -->
- [x] #54591 <!-- Don't expose guard pages to malloc_stack API consumers
-->
- [x] #54755 <!-- [TOML] remove Dates hack, replace with explicit usage
-->
- [x] #54721 <!-- add try/catch around scheduler to reset sleep state
-->
- [x] #54631 <!-- Avoid concatenating LazyString in setindex! for
triangular matrices -->
- [x] #54322 <!-- effects: add new `@consistent_overlay` macro -->
- [x] #54785
- [x] #54865
- [x] #54815
- [x] #54795
- [x] #54779
- [x] #54837 

Contains multiple commits, manual intervention needed:
- [ ] #52694 <!-- Reinstate similar for AbstractQ for backward
compatibility -->
- [ ] #54649 <!-- Less restrictive copyto! signature for triangular
matrices -->

Non-merged PRs with backport label:
- [ ] #54779 <!-- make recommendation clearer on manifest version
mismatch -->
- [ ] #54739 <!-- finish implementation of upgradable stdlibs -->
- [ ] #54738 <!-- serialization: fix relocatability bug -->
- [ ] #54574 <!-- Make ScopedValues public -->
- [ ] #54457 <!-- Make `String(::Memory)` copy -->
- [ ] #53957 <!-- tweak how filtering is done for what packages should
be precompiled -->
- [ ] #53452 <!-- RFC: allow Tuple{Union{}}, returning Union{} -->
- [ ] #53286 <!-- Raise an error when using `include_dependency` with
non-existent file or directory -->
- [ ] #51479 <!-- prevent code loading from lookin in the versioned
environment when building Julia -->
@KristofferC KristofferC removed the backport 1.11 Change should be backported to release-1.11 label Jun 25, 2024
@matthias314
Copy link
Contributor

matthias314 commented Sep 16, 2024 •
edited
Loading

What was the reason to replace foldl and foldr by loops? It seems to me that this has made append! and in particular prepend! slower:

julia> t = (1:2, 3:4, 5:6, 7:8);

julia> f1(v, t...) = foldl((v, w) -> append!(v, w), t; init = v);

julia> @b [1,2,3] append!(_, $t...) evals = 1
148.000 ns (6 allocs: 592 bytes)

julia> @b [1,2,3] f1(_, $t...) evals = 1
123.000 ns (2 allocs: 464 bytes)

julia> f2(v, t...) = foldr((w, v) -> prepend!(v, w), t; init = v);

julia> @b [1,2,3] prepend!(_, $t...) evals = 1
417.000 ns (12 allocs: 880 bytes)

julia> @b [1,2,3] f2(_, $t...) evals = 1
128.000 ns (2 allocs: 464 bytes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviatesk aviatesk aviatesk left review comments

Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack overflow during gc_read_stack on win32
6 participants
@vtjnash @staticfloat @giordano @matthias314 @aviatesk @KristofferC