Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Some improvements to the LLVM build system #55354

Merged
merged 4 commits into from
Aug 6, 2024
Merged

[build] Some improvements to the LLVM build system #55354

merged 4 commits into from
Aug 6, 2024

Commits on Aug 2, 2024

  1. [build] Set ZLIB_ROOT instead of ZLIB_LIBRARY 

    `ZLIB_LIBRARY` must be the path to the zlib library, but we currently set it to
the libdir where the library is installed, which is wrong.  Also, `ZLIB_ROOT` is
the only hint recommended by the CMake module `FindZLIB`:
<https://cmake.org/cmake/help/latest/module/FindZLIB.html#hints>.
    @giordano
    giordano committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    36d2caf View commit details
    Browse the repository at this point in the history

  2. [build] Remove non existing CMake options for LLVM

    @giordano
    giordano committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    afc2a9a View commit details
    Browse the repository at this point in the history

  3. [build] Set LLVM_ENABLE_ZLIB=FORCE_ON in LLVM build system 

    This makes tests to check zlib is usable error out loudly, instead of silently
proceeding with a broken build.
    @giordano
    giordano committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    63b606b View commit details
    Browse the repository at this point in the history

  4. [build] Fix options to find zlib in BOLT build system

    @giordano
    giordano committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    496702a View commit details
    Browse the repository at this point in the history