-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenBLAS_jll] Upgrade to new build to fix bug in threads buffers #55496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately I still see the segmentation fault. Putting on hold. |
Actually, I see it only on some machines, not everywhere. |
I see the segfault too. julia> versioninfo()
uJulia Version 1.12.0-DEV.1050
Commit 075d3a24d9 (2024-08-15 09:46 UTC)
Platform Info:
OS: Linux (x86_64-linux-gnu)
CPU: 8 × Intel(R) Core(TM) i5-10310U CPU @ 1.70GHz
WORD_SIZE: 64
LLVM: libLLVM-18.1.7 (ORCJIT, skylake)
Threads: 1 default, 0 interactive, 1 GC (on 8 virtual cores)
Environment:
JULIA_EDITOR = subl
julia> using LinearAlgebra
julia> BLAS.get_num_threads()
4
julia> H = Hermitian(rand(64, 64));
julia> eigen(H)
[62528] signal 11 (1): Segmentation fault
in expression starting at REPL[5]:1
Allocations: 2949222 (Pool: 2949141; Big: 81); GC: 4
[1] 62528 segmentation fault (core dumped) ./julia |
After backporting OpenMathLib/OpenBLAS#4879, this finally seems to work for me on all the machines where it was still segfaulting after the first patch:
|
Can confirm that this works for me now |
jishnub
approved these changes
Aug 15, 2024
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Aug 17, 2024
KristofferC
pushed a commit
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
building
Build system, or building Julia or its dependencies
external dependencies
Involves LLVM, OpenBLAS, or other linked libraries
JLLs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build backports OpenMathLib/OpenBLAS#4871. This should fix JuliaLang/LinearAlgebra.jl#1086. See also OpenMathLib/OpenBLAS#4868.