Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenBLAS_jll] Upgrade to new build to fix bug in threads buffers #55496

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

giordano
Copy link
Contributor

@giordano giordano added building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs labels Aug 15, 2024
@giordano giordano requested a review from jishnub August 15, 2024 09:50
@giordano giordano marked this pull request as draft August 15, 2024 10:14
@giordano
Copy link
Contributor Author

Unfortunately I still see the segmentation fault. Putting on hold.

@giordano
Copy link
Contributor Author

Actually, I see it only on some machines, not everywhere.

@jishnub
Copy link
Contributor

jishnub commented Aug 15, 2024

I see the segfault too.

julia> versioninfo()
uJulia Version 1.12.0-DEV.1050
Commit 075d3a24d9 (2024-08-15 09:46 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 8 × Intel(R) Core(TM) i5-10310U CPU @ 1.70GHz
  WORD_SIZE: 64
  LLVM: libLLVM-18.1.7 (ORCJIT, skylake)
Threads: 1 default, 0 interactive, 1 GC (on 8 virtual cores)
Environment:
  JULIA_EDITOR = subl

julia> using LinearAlgebra

julia> BLAS.get_num_threads()
4

julia> H = Hermitian(rand(64, 64));

julia> eigen(H)

[62528] signal 11 (1): Segmentation fault
in expression starting at REPL[5]:1
Allocations: 2949222 (Pool: 2949141; Big: 81); GC: 4
[1]    62528 segmentation fault (core dumped)  ./julia

@giordano giordano marked this pull request as ready for review August 15, 2024 14:54
@giordano
Copy link
Contributor Author

After backporting OpenMathLib/OpenBLAS#4879, this finally seems to work for me on all the machines where it was still segfaulting after the first patch:

$ ./julia-7527d47a09/bin/julia -q
julia> using LinearAlgebra

julia> eigen(Hermitian(ones(1024, 1024)));

julia>

@jishnub
Copy link
Contributor

jishnub commented Aug 15, 2024

Can confirm that this works for me now

@giordano giordano merged commit 015c2cb into JuliaLang:master Aug 15, 2024
7 checks passed
@giordano giordano deleted the mg/openblas branch August 15, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries JLLs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault in Hermitian eigen/eigvals on nightly
2 participants