Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace regex package module checks with actual code checks #55824

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Replace regex package module checks with actual code checks #55824

merged 6 commits into from
Sep 23, 2024

Commits on Sep 20, 2024

  1. handle outside package module import check via require

    @IanButterworth
    IanButterworth committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c81697a View commit details
    Browse the repository at this point in the history

  2. also detect when no package module is defined

    @IanButterworth
    IanButterworth committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    06a3d01 View commit details
    Browse the repository at this point in the history

  3. add more tests

    @IanButterworth
    IanButterworth committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3c844c6 View commit details
    Browse the repository at this point in the history

  4. add tip to error message

    @IanButterworth
    IanButterworth committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8486a4d View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. fix tests

    @IanButterworth
    IanButterworth committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    3a62625 View commit details
    Browse the repository at this point in the history

  2. rm loading test_throws given we now fail earlier during precompilation

    @IanButterworth
    IanButterworth committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    01c8731 View commit details
    Browse the repository at this point in the history