Backports release 1.11 #55855
Merged
Backports release 1.11 #55855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 346f38b)
`%M` is the format specifier for the minutes, not the month (which should be `%m`), and it was used twice. Also, on macOS `Libc.strptime` internally calls `mktime` which depends on the local timezone. We now temporarily set `TZ=UTC` to avoid depending on the local timezone. Fix #55827. (cherry picked from commit d6fa66f)
(cherry picked from commit fc9f147)
This change protects `@assert` from invalidations to `Base.string(...)`
by adding an `invokelatest` barrier.
A common source of invalidations right now is `print(io,
join(args...))`. The problem is:
1. Inference concludes that `join(::Any...)` returns
`Union{String,AnnotatedString}`
2. The `print` call is union-split to `String` and `AnnotatedString`
3. This code is now invalidated when StyledStrings defines `print(io,
::AnnotatedString)`
The invalidation chain for `@assert` is similar: ` @Assert 1 == 1` calls
into `string(::Expr)` which calls into `print(io, join(args::Any...))`.
Unfortunately that leads to the invalidation of almost all `@assert`s
without an explicit error message
Similar to
#55583 (comment)
(cherry picked from commit 945517b)
KristofferC
force-pushed
the
backports-release-1.11
branch
from
578cb0f
to
2259c79
Compare
…55783) This version would be better as per this comment: <#55739 (review)> I confirmed this still allows us to avoid invalidations reported at #55583. (cherry picked from commit f808606)
Stdlib: Downloads URL: https://github.com/JuliaLang/Downloads.jl.git Stdlib branch: master Julia branch: master Old commit: 1061ecc New commit: 89d3c7d Julia version: 1.12.0-DEV Downloads version: 1.6.0(It's okay that it doesn't match) Bump invoked by: @KristofferC Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaLang/Downloads.jl@1061ecc...89d3c7d ``` $ git log --oneline 1061ecc..89d3c7d 89d3c7d fix cancelling upload requests (#259) df33406 gracefully cancel a request (#256) ``` Co-authored-by: Dilum Aluthge <dilum@aluthge.com> (cherry picked from commit c3af4fc)
aviatesk
force-pushed
the
backports-release-1.11
branch
from
e341838
to
0e17bd7
Compare
|
The cherry-picked commit for the parser fix seems to be broken? Currently this branch doesn't bootstrap: |
KristofferC
force-pushed
the
backports-release-1.11
branch
from
5c4fc50
to
0e17bd7
Compare
|
I dropped it |
|
Added a PR to update NEWS.md: #55858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
Base.donotdelete#55773cderror when working dir has been deleted #41244@docof macro without REPL loaded #55795inferencebarrierinstead ofinvokelatestfor 1-arg@assert#55783invokelatestbarrier tostring(...)in@assert#55739Need manual backport:
Contains multiple commits, manual intervention needed:
Non-merged PRs with backport label:
isapproxwith unsigned integers #55828@ccallablename before JIT registration #55813displaysizeto theIOContextused by the REPL #55499isfile_casesensitivefixes on Windows #55220propertynamesfor SVD respects private argument #55169String(::Memory)copy #54457@inboundsandBase.@propagate_inbounds#50157