Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inference: fix inference error from constructing invalid TypeVar #56264

Merged
merged 1 commit into from
Oct 21, 2024
Merged

inference: fix inference error from constructing invalid TypeVar #56264

merged 1 commit into from
Oct 21, 2024

Conversation

aviatesk
Copy link
Member

@aviatesk aviatesk merged commit 08d11d0 into master Oct 21, 2024
7 checks passed
@aviatesk aviatesk deleted the avi/56248 branch October 21, 2024 20:23
@nsajko
Copy link
Contributor

nsajko commented Oct 21, 2024

Is this backportable to v1.10, v1.11?

@oscardssmith oscardssmith added bugfix This change fixes an existing bug compiler:inference Type inference backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 labels Oct 22, 2024
@oscardssmith
Copy link
Member

looks pretty backportable.

@KristofferC KristofferC mentioned this pull request Oct 29, 2024
Merged
47 tasks
KristofferC pushed a commit that referenced this pull request Oct 30, 2024
@aviatesk
inference: fix inference error from constructing invalid TypeVar (#…
b23811e 
…56264)

- fixes #56248

(cherry picked from commit 08d11d0)
KristofferC pushed a commit that referenced this pull request Oct 30, 2024
@aviatesk
inference: fix inference error from constructing invalid TypeVar (#…
d48243f 
…56264)

- fixes #56248

(cherry picked from commit 08d11d0)
@topolarity
Copy link
Member

The backport of this broke the tests on 1.10 (Base.infer_return_type does not exist on 1.10)

@topolarity topolarity mentioned this pull request Oct 30, 2024
Merged
@nsajko
Copy link
Contributor

nsajko commented Oct 30, 2024 •
edited
Loading

I'm guessing Core.Compiler.return_type should be used instead of Base.infer_return_type.

@aviatesk
Copy link
Member Author

I general we should use Base.infer_return_type or Base.return_types instead of Core.Compiler.return_type for inference quality tests.

@nsajko
Copy link
Contributor

nsajko commented Oct 30, 2024

Base.infer_return_type does not exist on 1.10

@KristofferC
Copy link
Member

bb86259 I guess (I had already made that change locally and forgotten to push the whole part, I only pushed the only part of it).

KristofferC added a commit that referenced this pull request Nov 12, 2024
@KristofferC
Backports for Julia 1.10.7 (#56381)
9ee861f 
Backported PRs:
- [x] #50832 <!-- Subtype: bug fix for bounds with deeper covariant var
-->
- [x] #51782 <!-- Fix remove-addrspaces pass in the presence of globals
with addrspaces -->
- [x] #55720 <!-- Fix `pkgdir` for extensions -->
- [x] #55773 <!-- Add compat entry for `Base.donotdelete` -->
- [x] #55886 <!-- irrationals: restrict assume effects annotations to
known types -->
- [x] #55867 <!-- update `hash` doc string: `widen` not required any
more -->
- [x] #56148 <!-- Make loading work when stdlib deps are missing in the
manifest -->
- [x] #55870 <!-- fix infinite recursion in `promote_type` for
`Irrational` -->
- [x] #56252 <!-- REPL: fix brace detection when ' is used for transpose
-->
- [x] #56264 <!-- inference: fix inference error from constructing
invalid `TypeVar` -->
- [x] #56276 <!-- move time_imports and trace_* macros to Base but
remain owned by InteractiveUtils -->
- [x] #56254 <!-- REPL: don't complete str and cmd macros when the input
matches the internal name like `r_` to `r"` -->
- [x] #56280 <!-- Fix trampoline warning on x86 as well -->
- [x] #56304 <!-- typeintersect: more fastpath to skip intersect under
circular env -->
- [x] #56306 <!-- InteractiveUtils.jl: fixes issue where subtypes
resolves bindings and causes deprecation warnings -->
- [x] #42080 <!-- recommend explicit `using Foo: Foo, ...` in package
code (was: "using considered harmful") -->
- [x] #56441 <!-- Profile: mention `kill -s SIGUSR1 julia_pid` for Linux
-->
- [x] #56511 <!-- The `info` in LAPACK calls should be a Ref instead of
a Ptr -->
- [x] #55052 <!-- Fix `(l/r)mul!` with `Diagonal`/`Bidiagonal` -->
- [x] #52694 <!-- Reinstate similar for AbstractQ for backward
compatibility -->
This was referenced Nov 22, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 bugfix This change fixes an existing bug compiler:inference Type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A TypeError crashes Julia
6 participants
@aviatesk @nsajko @oscardssmith @topolarity @KristofferC @vtjnash