Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a forgotten rename readuntil -> copyuntil #56380

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix a forgotten rename readuntil -> copyuntil #56380

merged 1 commit into from
Oct 29, 2024

Conversation

KristofferC
Copy link
Member

Fixes #56352, with the repro in that issue:

Master:
  1.114874 seconds (13.01 M allocations: 539.592 MiB, 3.80% gc time)

After:
   0.369492 seconds (12.99 M allocations: 485.031 MiB, 10.73% gc time)

1.10:
    0.341114 seconds (8.36 M allocations: 454.242 MiB, 2.69% gc time)

@KristofferC KristofferC added the backport 1.11 Change should be backported to release-1.11 label Oct 29, 2024
@vtjnash vtjnash merged commit 07530bc into master Oct 29, 2024
5 of 8 checks passed
@vtjnash vtjnash deleted the kc/ru_to_cu branch October 29, 2024 14:42
@oscardssmith oscardssmith added the performance Must go faster label Oct 29, 2024
KristofferC added a commit that referenced this pull request Nov 11, 2024
Fixes #56352, with the repro in
that issue:

```
Master:
  1.114874 seconds (13.01 M allocations: 539.592 MiB, 3.80% gc time)

After:
   0.369492 seconds (12.99 M allocations: 485.031 MiB, 10.73% gc time)

1.10:
    0.341114 seconds (8.36 M allocations: 454.242 MiB, 2.69% gc time)
```

(cherry picked from commit 07530bc)
@KristofferC KristofferC removed the backport 1.11 Change should be backported to release-1.11 label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Julia v1.11.1 regression: open(::Cmd) is 4X slower than v1.10.4
4 participants