compiler: fix specialization mistake introduced by #40985 #56404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIUC the previous implementation has caused unnecessary and useless specializations with the closure type, right? If so, my understanding is that this is a phenomenon caused by our approach to closure construction itself, rather than being specifically triggered by #40985. |
|
Previously to #40985 this was just DataType there, so it was fine |
vtjnash
added a commit
that referenced
this pull request
Nov 1, 2024
vtjnash
added a commit
that referenced
this pull request
Nov 5, 2024
vtjnash
added a commit
that referenced
this pull request
Nov 13, 2024
Keno
pushed a commit
that referenced
this pull request
Nov 14, 2024
vtjnash
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully there aren't any others like this hiding around? Not useful to make a new closure for every method that we inline, since we just called
===inside it