optimize abstract_invoke
#56560
Merged
optimize abstract_invoke
#56560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed unnecessary `Core.Box` allocation - make the type of the closure that is passed to `Future` concrete That said, it doesn’t seem ideal to require this sort of manual optimizations.. The value of using closures cannot be denied in this code base, and I feel that it would be better to work towards optimizing closures more?
aviatesk
commented
Nov 14, 2024
Comment on lines
-2185
to
+2186
| match, valid_worlds = findsup(lookupsig, method_table(interp)) | ||
| match === nothing && return Future(CallMeta(Any, Any, Effects(), NoCallInfo())) | ||
| matched, valid_worlds = findsup(lookupsig, method_table(interp)) | ||
| matched === nothing && return Future(CallMeta(Any, Any, Effects(), NoCallInfo())) |
There was a problem hiding this comment.
This is an instance of #56561.
vtjnash
approved these changes
Nov 14, 2024
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core.BoxallocationFutureconcreteThat said, it doesn’t seem ideal to require this sort of manual optimizations.. The value of using closures cannot be denied in this code base, and I feel that it would be better to work towards optimizing closures more (as we do with #56532)?
@nanosoldier
runbenchmarks("inference", vs=":master")