Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make version of opaque closure constructor in world #56823

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wsmoses
Copy link
Contributor

@wsmoses wsmoses commented Dec 14, 2024

Successor to #56808 which enables an opaque closure to be constructed with a specified world age (if, for example, the current world age isn't valid due to being in a generated function). Required for EnzymeAD/Reactant.jl#365

@wsmoses wsmoses requested review from vtjnash, vchuravy and Keno December 14, 2024 06:25
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, the standard thing to do before for this was to call this Base.invoke_in_world(world, generate_opaque_closure, args...), which seems unnecessarily convoluted just to pass this extra argument to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants